Date: Thu, 07 Feb 2002 14:50:21 +0100 From: "FEREAU Hugues"
Organization: SWIFT
CK, After lot of testing, we arrive at the conclusion that ... your product works perfect for us ! We succeded to upload several large files at the same time (up to 180Mb successfully - but we didn't check the exact limitation, as it depends closely on the memory available)
There are just some little changes we would like you to investigate :
blocking
the save() method in UploadedFile never throws any IOException. As a result, we can't guess if the save() is successfull or not. We would like the save() method to throw any IOException its encounters in a general way, I think your classes should not catch any exception at all, or at least rethrow them. So we can build more customisable application around it.
major
i tried to upload a file that doesn't exist on my local disk (i used a wrong name) and the file was accepted, and saved with a size of 0 bytes. A method to check if the file exists or not would be very usefull (boolean UploadedFile.isMissing() ) a check to restrict files extension would be also of a great help.
Could you implement such a method in the FileUploadPro class ? And also a method to get the fileextention in the UploadedFile class ? The FileUploadPro could also have a method Enumeration getFiles() that returns a set of UploadedFile objects Is it possible to have a method getFields() in FileUploadPro that returns all the fields in the request posted ?
minor
To look like more standard with beans, getter and setter methods to read/write filename and savePath fields in UploadedFile would be appreciated. (Should not be a big deal for you) nice-to-have The files are saved with a physical path. Do you think it's possible to save them with a virtual path ? Tell us, which change you can do and my colleague VanKham will contact you for the purchasing aspects. thanks a lot
yougs.